Skip to content

Utilize RecipeManager and TagManager from Redstone Transformer#1116

Merged
mastercoms merged 7 commits intoGlowstoneMC:devfrom
smartboyathome:data-pack-recipes-tags
Jul 14, 2021
Merged

Utilize RecipeManager and TagManager from Redstone Transformer#1116
mastercoms merged 7 commits intoGlowstoneMC:devfrom
smartboyathome:data-pack-recipes-tags

Conversation

@smartboyathome
Copy link
Contributor

This PR swaps out the tags and recipe manager implementations for their counterparts from the redstone transformer. This allows us to get this data from the default datapack easily without keeping that data around and without having to hardcode these recipes. The implementations differ slightly from their Glowstone counterparts, but usually only in name. We may want to switch away from using the MaterialSetTag class to our own wrapper around SubTagTrackingTag in order to allow for modifications to these custom tags to be tracked in the future.

@mastercoms
Copy link
Member

Also, I am not sure how relevant materialValues.yml and fishingRewards.yml will be once Redstone Transformer is done, but if they will still be relevant, could you add tag support to both of them?

@smartboyathome
Copy link
Contributor Author

materialValues.yml currently doesn't have an equivalent in the Redstone Transformer. The data this file contains isn't available from Mojang itself through data packs, but it looks like it is available in PrismarineJS's minecraft-data.

For fishingRewards.yml, this should eventually be replaced by the fishing loot table in Mojang's official data pack.

@mastercoms
Copy link
Member

@smartboyathome Could you resolve merge conflicts? Should be good after that.

@mastercoms mastercoms merged commit e16336e into GlowstoneMC:dev Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants