Utilize RecipeManager and TagManager from Redstone Transformer#1116
Merged
mastercoms merged 7 commits intoGlowstoneMC:devfrom Jul 14, 2021
Merged
Utilize RecipeManager and TagManager from Redstone Transformer#1116mastercoms merged 7 commits intoGlowstoneMC:devfrom
mastercoms merged 7 commits intoGlowstoneMC:devfrom
Conversation
mastercoms
requested changes
Jul 11, 2021
Member
|
Also, I am not sure how relevant |
Contributor
Author
|
materialValues.yml currently doesn't have an equivalent in the Redstone Transformer. The data this file contains isn't available from Mojang itself through data packs, but it looks like it is available in PrismarineJS's minecraft-data. For fishingRewards.yml, this should eventually be replaced by the fishing loot table in Mojang's official data pack. |
Member
|
@smartboyathome Could you resolve merge conflicts? Should be good after that. |
mastercoms
approved these changes
Jul 14, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR swaps out the tags and recipe manager implementations for their counterparts from the redstone transformer. This allows us to get this data from the default datapack easily without keeping that data around and without having to hardcode these recipes. The implementations differ slightly from their Glowstone counterparts, but usually only in name. We may want to switch away from using the MaterialSetTag class to our own wrapper around SubTagTrackingTag in order to allow for modifications to these custom tags to be tracked in the future.