Skip to content

Gradle 7.1 #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2021
Merged

Gradle 7.1 #1117

merged 1 commit into from
Jul 14, 2021

Conversation

VaiTon
Copy link
Contributor

@VaiTon VaiTon commented Jul 12, 2021 •
edited
Loading

Closes #975

@VaiTon VaiTon force-pushed the gradle branch 2 times, most recently from 1fd15e6 to 9cbe3e4 Compare July 12, 2021 13:19
smartboyathome
smartboyathome requested changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@smartboyathome smartboyathome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those two changes are my only gripes with this, but I would prefer if @gdude2002 also reviewed this.

@gdude2002 gdude2002 self-requested a review July 12, 2021 15:59
gdude2002
gdude2002 suggested changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@gdude2002 gdude2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good, just a couple of things. You can consider this a "+1" to the other review comments as well.

@VaiTon VaiTon requested a review from gdude2002 July 13, 2021 10:19
@mastercoms mastercoms merged commit 42949b9 into GlowstoneMC:dev Jul 14, 2021
@VaiTon VaiTon deleted the gradle branch July 15, 2021 00:03
@mastercoms mastercoms mentioned this pull request Jul 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdude2002 gdude2002 gdude2002 approved these changes

@smartboyathome smartboyathome smartboyathome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gradle building
4 participants
@VaiTon @gdude2002 @smartboyathome @mastercoms