Make Glowstone colorful again! (1.12) #477
Conversation
|
Updated with a detailed task list. |
| } | ||
| String gm = args[0].toLowerCase(); | ||
| GameMode gamemode = null; | ||
| switch (gm) { |
There was a problem hiding this comment.
I think there is a default case for survival.
There was a problem hiding this comment.
Although, in Vanilla, using an incorrect GameMode ID prints out 'x' is not a valid number!.
There was a problem hiding this comment.
Hm, maybe this was changed. IIRC it used to change to survival on invalid numbers.
Attempted default permission for /say, doesn't work?
/say shouldn't be permitted to default users
| @@ -931,7 +932,7 @@ private void enablePlugins(PluginLoadOrder type) { | |||
| // Default permissions | |||
| this.permissionRoot = DefaultPermissions.registerPermission("minecraft", "Gives the user the ability to use all Minecraft utilities and commands"); | |||
| this.permissionCommand = DefaultPermissions.registerPermission("minecraft.command", "Gives the user the ability to use all Minecraft commands", permissionRoot); | |||
| DefaultPermissions.registerPermission("minecraft.command.say", "Allows the user to speak using a command", PermissionDefault.TRUE, permissionCommand); | |||
There was a problem hiding this comment.
Why was the default say permission removed?
There was a problem hiding this comment.
/say is not a default command :) ((you can do /say @e for example, which shouldn't be possible for non-ops))
There was a problem hiding this comment.
Oh hm, I guess I was thinking of a plugin that replaced say, which only sent a chat message like you would normally, instead of broadcasting the message.
| if (name == null || name.isEmpty()) { | ||
| name = entity.getType().getName(); | ||
| } | ||
| if (entity.getCustomName() != null && !entity.getCustomName().isEmpty()) { |
There was a problem hiding this comment.
People can name an entity as an empty string, right? I think it would be better to show type:name, but depends on what vanilla does.
|
Glowkit was still not updated to revert this change: https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/commits/a1cc4b769caf690b2f075f833c83e76d6431f9a7#src/main/java/org/bukkit/command/SimpleCommandMap.java. Glowstone's vanilla command implementations will override any plugin commands with conflicting names. |
|
@mastercoms Are we good to go? (GlowstoneMC/Glowkit@929fa4d, once Glowkit will be deployed) e: ok I'll change our command implementations to |
1.12, the World of Color update. Will await Mojang's final release before merge (release planned for Friday, June 2nd).
Blocking changes:
New features (optional):
doLimitedCraftingRecipesNBT and ItemMeta)announceAdvancementsgameLoopFunctionLoveCauseLeast,LoveCauseMost)ConversionPlayerLeast,ConversionPlayerMost)@ sselectorreloadDatamethod)