New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Glowstone colorful again! (1.12) #477

Merged
merged 64 commits into from Jun 9, 2017

Conversation

Projects
None yet
2 participants
@mastercoms
Copy link
Member

mastercoms commented May 24, 2017

1.12, the World of Color update. Will await Mojang's final release before merge (release planned for Friday, June 2nd).

Blocking changes:

  • Network
    • Minecraft and protocol version updates
    • Packet ID changes
    • Client status packet change
  • Dependency updates
    • Maven dependencies
    • Library manager downloads
    • Remove usage of Apache Commons
  • Bukkit API changes
    • Method stubs
      • New command sender API stubs
      • Advancement API stubs
    • Removal of deprecated/invalid methods
    • Add important vanilla commands which were removed from Bukkit
    • Allow overriding vanilla commands with plugins
  • New sounds
    • Sound IDs
  • Item IDs
  • Do not drop pending inventory items (implemented in snapshots branch)

New features (optional):

  • Recipes
    • Basic server side tracking of recipes (50% complete, relies mostly on packet implementation)
    • Recipe packets
    • /recipe
    • Game rule doLimitedCrafting
    • Knowledge book
      • Base class implementation
      • Recipe learning (Recipes NBT and ItemMeta)
  • New note block sounds
  • Bukkit API updates
    • New command sender API implementations
    • New spellcaster interface
    • Glowkit changes
  • Advancements
    • API implementation
    • /advancement
    • Game rule announceAdvancements
    • Data representation and JSON reading
    • Advancement packets
  • Functions
    • /function
    • Function files
    • Game rule gameLoopFunction
  • New NBT
    • New breed UUIDs (LoveCauseLeast, LoveCauseMost)
    • Zombie NBT tags (ConversionPlayerLeast, ConversionPlayerMost)
    • Player NBT
      • Recipe book
      • Seen credits
      • Shoulders
  • New command features
    • @ s selector
    • /reload (and Bukkit reloadData method)
    • Add other commands that were removed from Bukkit
  • Blocks
    • Concrete power
      • Recipe
      • Block functionality (falling, dry into concrete)
    • Concrete
      • Block functionality (direct drops?)
    • Glazed Terracotta
      • Recipe
      • Facing
    • Beds
      • Sleep when neutral pigman is near
      • Reduce fall damage on landing on bed
      • Colored beds
    • Magma blocks burning like netherrack
    • Stairs support attachments on rear and underside
  • Entities
    • Parrot
      • Sitting
      • Shoulder sitting (implemented in snapshots branch)
      • Shoulder removal (in water or jumping, but not with elytra)
      • Dancing (anything we need to do?)
      • Taming
      • Cookie poisoning
      • Data
      • Loot
      • Imitation
    • Illusioner
      • Blindness
      • Illusions
      • Targeting players and villagers
@mastercoms

This comment has been minimized.

Copy link
Member Author

mastercoms commented May 25, 2017

Updated with a detailed task list.

}
String gm = args[0].toLowerCase();
GameMode gamemode = null;
switch (gm) {

This comment has been minimized.

@mastercoms

mastercoms May 25, 2017

Author Member

I think there is a default case for survival.

This comment has been minimized.

@momothereal

momothereal May 26, 2017

Member

Although, in Vanilla, using an incorrect GameMode ID prints out 'x' is not a valid number!.

This comment has been minimized.

@mastercoms

mastercoms May 26, 2017

Author Member

Hm, maybe this was changed. IIRC it used to change to survival on invalid numbers.

@mastercoms mastercoms force-pushed the 1.12-staging branch from 45a6fd5 to fbe6b63 Jun 1, 2017

mastercoms and others added some commits Jun 1, 2017

/tell command
/say shouldn't be permitted to default users
@@ -931,7 +932,7 @@ private void enablePlugins(PluginLoadOrder type) {
// Default permissions
this.permissionRoot = DefaultPermissions.registerPermission("minecraft", "Gives the user the ability to use all Minecraft utilities and commands");
this.permissionCommand = DefaultPermissions.registerPermission("minecraft.command", "Gives the user the ability to use all Minecraft commands", permissionRoot);
DefaultPermissions.registerPermission("minecraft.command.say", "Allows the user to speak using a command", PermissionDefault.TRUE, permissionCommand);

This comment has been minimized.

@mastercoms

mastercoms Jun 2, 2017

Author Member

Why was the default say permission removed?

This comment has been minimized.

@momothereal

momothereal Jun 2, 2017

Member

/say is not a default command :) ((you can do /say @e for example, which shouldn't be possible for non-ops))

This comment has been minimized.

@mastercoms

mastercoms Jun 2, 2017

Author Member

Oh hm, I guess I was thinking of a plugin that replaced say, which only sent a chat message like you would normally, instead of broadcasting the message.

if (name == null || name.isEmpty()) {
name = entity.getType().getName();
}
if (entity.getCustomName() != null && !entity.getCustomName().isEmpty()) {

This comment has been minimized.

@mastercoms

mastercoms Jun 2, 2017

Author Member

People can name an entity as an empty string, right? I think it would be better to show type:name, but depends on what vanilla does.

This comment has been minimized.

@momothereal

momothereal Jun 2, 2017

Member

Ok I can test this tonight

mastercoms and others added some commits Jun 2, 2017

@mastercoms

This comment has been minimized.

Copy link
Member Author

mastercoms commented Jun 9, 2017

Glowkit was still not updated to revert this change: https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/commits/a1cc4b769caf690b2f075f833c83e76d6431f9a7#src/main/java/org/bukkit/command/SimpleCommandMap.java. Glowstone's vanilla command implementations will override any plugin commands with conflicting names.

@momothereal

This comment has been minimized.

Copy link
Member

momothereal commented Jun 9, 2017

@mastercoms Are we good to go? (GlowstoneMC/Glowkit@929fa4d, once Glowkit will be deployed)

e: ok I'll change our command implementations to VanillaCommand here first.

@momothereal momothereal merged commit 75cbccb into master Jun 9, 2017

1 check was pending

ci/circleci CircleCI is running your tests
Details

@momothereal momothereal deleted the 1.12-staging branch Jul 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment