New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This fixes the effect command not accepting vanilla ids #558

Merged
merged 1 commit into from Sep 1, 2017

Conversation

Projects
None yet
2 participants
@schweinefilet
Contributor

schweinefilet commented Sep 1, 2017

I'm currently making the enchant command and realized that the effect command has no vanilla ids mapped to the appropriate potion effect types. This commit should fix this.

This fixes the effect command not accepting vanilla ids.
Some Bukkit names for potions are not the same as the vanilla ids, so even though the potions were auto completed with vanilla names, some potions could not be found. For example mining_fatigue is called slow_digging.

@mastercoms mastercoms merged commit 82bd35c into GlowstoneMC:master Sep 1, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@schweinefilet schweinefilet deleted the schweinefilet:effect-vanilla-fix branch Sep 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment