New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement critical hit + damage enchantment amplification #564

Merged
merged 4 commits into from Sep 10, 2017

Conversation

Projects
None yet
2 participants
@momothereal
Member

momothereal commented Sep 10, 2017

Note: GlowstoneMC/Glowkit#14 and #563 have to be merged first.

Implements critical hits, as well as some enchantments:

  • Sharpness
  • Smite
  • Bane of Arthropods

It also implements the new Entity Animation API (GlowstoneMC/Glowkit#14)

Note: I tested this

@momothereal

This comment has been minimized.

Show comment
Hide comment
@momothereal

momothereal Sep 10, 2017

Member

Build failed because #563 hasn't been merged yet.

Member

momothereal commented Sep 10, 2017

Build failed because #563 hasn't been merged yet.

@momothereal

This comment has been minimized.

Show comment
Hide comment
@momothereal

momothereal Sep 10, 2017

Member

This PR also depends on GlowstoneMC/Glowkit#14 (Entity animation API)

Member

momothereal commented Sep 10, 2017

This PR also depends on GlowstoneMC/Glowkit#14 (Entity animation API)

@mastercoms mastercoms merged commit a427bb2 into GlowstoneMC:master Sep 10, 2017

1 of 2 checks passed

ci/circleci Your tests failed on CircleCI
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment