New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix food features and update food values #578

Merged
merged 1 commit into from Oct 22, 2017

Conversation

Projects
None yet
2 participants
@kaenganxt
Member

kaenganxt commented Oct 22, 2017

This pull request fixes some food related features and updates the food values like restored hunger, saturation and the applied potion effects.

The following things are done by this PR:

  • Update restored hunger and saturation according to the Minecraft wiki
  • New ItemSoup class which returns an empty bowl to the player
  • Added beetroot, beetroot soup and chorus fruit as food
  • Update potion effect chances, durations and levels according to the Minecraft wiki and some additional investigation
  • Changed the food potion effects to use new PotionEffect(...) because the old version uses the "duration modifiers" (I have no clue why these exist) which change the given duration depending on the potion effect resulting in wrong durations applied to the player
  • Use an equals in the eating logic as getItemInHand returns a copy of the itemstack object

@momothereal momothereal self-requested a review Oct 22, 2017

@momothereal momothereal merged commit 1dd0368 into GlowstoneMC:master Oct 22, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details
@momothereal

This comment has been minimized.

Show comment
Hide comment
@momothereal

momothereal Oct 22, 2017

Member

Thanks!

Member

momothereal commented Oct 22, 2017

Thanks!

PickNChew added a commit to PickNChew/Glowstone that referenced this pull request Oct 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment