New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move array of BlockFaces to BlockType #583

Merged
merged 1 commit into from Oct 30, 2017

Conversation

Projects
None yet
2 participants
@kaenganxt
Member

kaenganxt commented Oct 30, 2017

This PR moves many of the used BlockFace arrays to the BlockType parent class.

As the same arrays (one with the horizontal BlockFaces and one with additional up and down faces) are used over and over in the BlockType implementations, I moved these two arrays to a central place and renamed similiar arrays.

In case the order of the array was important and different from the default order, I didn't change the BlockFace array.

@momothereal momothereal merged commit 6ecd65a into GlowstoneMC:master Oct 30, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@kaenganxt kaenganxt deleted the kaenganxt:faces branch Dec 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment