New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pinging the server in proxy mode #599

Merged
merged 1 commit into from Dec 9, 2017

Conversation

Projects
None yet
3 participants
@kaenganxt
Member

kaenganxt commented Dec 9, 2017

This pull request fixes an issue with pinging a Glowstone server from BungeeCord.

BungeeCord provides a ServerInfo.ping() method, which returns the server list information from the given server.

Since there's no need to send additional information (like the uuid of a player), the address field of the handshake message behaves just like a direct packet from a vanilla client. That means the only case where additional bungeecord data has to be parsed, is when the handshake is performed for a login process.

The old version tried to parse the address string, failed when checking the length of the data and disconnected the session, so BungeeCord never received the correct packet.

A side-effect of this change is that pinging the Glowstone server directly from a Minecraft client is possible even when proxy support is enabled. Connecting without a proxy is still not possible.

PS: If you're wondering where all the issues and pull requests come from, @hibo98 and I are currently trying to migrate the lobby of our server to Glowstone and these are the bugs we encounter.

And thanks for adding me to the team :).

@mastercoms mastercoms merged commit cc3cdc1 into GlowstoneMC:dev Dec 9, 2017

1 check passed

license/cla Contributor License Agreement is signed.
Details
@mastercoms

This comment has been minimized.

Member

mastercoms commented Dec 9, 2017

Thank you for continued contributions and dedication to Glowstone. The team add is well deserved :) and I should have done it sooner.

@kaenganxt kaenganxt deleted the kaenganxt:bungeePing branch Dec 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment