New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First-pass partial implementation of sendMap #605

Merged
merged 4 commits into from Dec 17, 2017

Conversation

Projects
None yet
4 participants
@Pr0methean
Contributor

Pr0methean commented Dec 17, 2017

Will send blank maps until GlowMapRenderer.render() is implemented.
Partial fix for #572

First-pass partial implementation of sendMap
Will send blank maps until GlowMapRenderer.render() is implemented.
@CLAassistant

This comment has been minimized.

CLAassistant commented Dec 17, 2017

CLA assistant check
All committers have signed the CLA.

@mastercoms

This comment has been minimized.

Member

mastercoms commented Dec 17, 2017

Thank you for your pull request to Glowstone! I would recommend making your PR on a separate branch on your fork, so you can easily create new PRs. But this is fine for now.

@Pr0methean

This comment has been minimized.

Contributor

Pr0methean commented Dec 17, 2017

Thanks! I've created a new branch for all future PRs.

@momothereal momothereal merged commit 89f3731 into GlowstoneMC:dev Dec 17, 2017

2 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details
@momothereal

This comment has been minimized.

Member

momothereal commented Dec 17, 2017

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment