Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First-pass partial implementation of sendMap #605

Merged
merged 4 commits into from Dec 17, 2017
Merged

First-pass partial implementation of sendMap #605

merged 4 commits into from Dec 17, 2017

Conversation

@Pr0methean
Copy link
Contributor

@Pr0methean Pr0methean commented Dec 17, 2017

Will send blank maps until GlowMapRenderer.render() is implemented.
Partial fix for #572

Will send blank maps until GlowMapRenderer.render() is implemented.
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Dec 17, 2017

CLA assistant check
All committers have signed the CLA.

@mastercoms
Copy link
Member

@mastercoms mastercoms commented Dec 17, 2017

Thank you for your pull request to Glowstone! I would recommend making your PR on a separate branch on your fork, so you can easily create new PRs. But this is fine for now.

@Pr0methean
Copy link
Contributor Author

@Pr0methean Pr0methean commented Dec 17, 2017

Thanks! I've created a new branch for all future PRs.

@aramperes aramperes merged commit 89f3731 into GlowstoneMC:dev Dec 17, 2017
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details
@aramperes
Copy link
Member

@aramperes aramperes commented Dec 17, 2017

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants