Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a slf4j back-end to pom.xml #612

Merged
merged 1 commit into from Dec 17, 2017
Merged

Add a slf4j back-end to pom.xml #612

merged 1 commit into from Dec 17, 2017

Conversation

@Pr0methean
Copy link
Contributor

@Pr0methean Pr0methean commented Dec 17, 2017

Fixes #606
Used only by a library, not by Glowstone itself.

@aramperes
Copy link
Member

@aramperes aramperes commented Dec 17, 2017

Since Glowstone doesn't use it, I think it should be added to the library manager and downloaded at runtime instead. Thoughts @mastercoms?

@Pr0methean
Copy link
Contributor Author

@Pr0methean Pr0methean commented Dec 17, 2017

That will only fix it if the library that uses slf4j hasn't already invoked LoggerFactory.

@mastercoms
Copy link
Member

@mastercoms mastercoms commented Dec 17, 2017

This is fine for now. I'll leave the issue open until we get a new library management system that does a proper fix to it.

@mastercoms mastercoms merged commit 863f144 into GlowstoneMC:dev Dec 17, 2017
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants