New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up chunk locking code. #623

Merged
merged 1 commit into from Dec 21, 2017

Conversation

Projects
None yet
3 participants
@smartboyathome
Contributor

smartboyathome commented Dec 20, 2017

Looking for some feedback on this. I found this portion of the chunk code confusing, mostly revolving around having a set of ChunkLocks, which contain a set of keys within them. I refactored this, changing it to a Key Multiset in order to try to make the intent a bit clearer.

@smartboyathome smartboyathome merged commit f3d6c96 into GlowstoneMC:dev Dec 21, 2017

2 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment