New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate BossBarManager #641

Merged
merged 4 commits into from Dec 24, 2017

Conversation

Projects
None yet
3 participants
@Pr0methean
Contributor

Pr0methean commented Dec 23, 2017

No description provided.

@Pr0methean Pr0methean requested a review from kamcio96 Dec 23, 2017

Pr0methean added some commits Dec 23, 2017

Bug fix
Can't use ConcurrentSkipListSet since GlowBossBar isn't Comparable
@kamcio96

This comment has been minimized.

Member

kamcio96 commented Dec 23, 2017

For me seems good, buy I don't have time to test it :/

@Pr0methean

This comment has been minimized.

Contributor

Pr0methean commented Dec 24, 2017

I've tested it with #642.

@Pr0methean Pr0methean merged commit f0cd032 into GlowstoneMC:dev Dec 24, 2017

2 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@Pr0methean Pr0methean deleted the Pr0methean:bossbars2 branch Dec 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment