New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous UUID lookups in commands #814

Merged
merged 6 commits into from Jan 22, 2018

Conversation

Projects
None yet
2 participants
@momothereal
Member

momothereal commented Jan 19, 2018

Makes commands that need to lookup UUIDs do so asynchronously. Should prevent server hanging as described in #111.

Commands in this PR: /op, /deop, /ban, /pardon, /whitelist <add|remove>

See todos: we should have a way to 'return' command success asynchronously for these commands. This isn't possible with the current API, but it might be needed as we get command blocks working. Not a pressing issue anyway because I doubt people will use /op & co in command blocks.

momothereal added some commits Jan 22, 2018

@mastercoms mastercoms merged commit d762f20 into dev Jan 22, 2018

2 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@mastercoms mastercoms deleted the issues/111 branch Jan 22, 2018

momothereal added a commit that referenced this pull request Feb 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment