New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implementation of Player.getVirtualHost()/getProtocolVersion() #824

Merged
merged 1 commit into from Jan 28, 2018

Conversation

Projects
None yet
5 participants
@Minecrell
Contributor

Minecrell commented Jan 28, 2018

Right now, Player.getVirtualHost() returns the client's IP address. However, it is actually supposed to return the hostname/port the player used to connect to the server.

Correct this and also make use of the version information in GlowSession instead of just returning the constant.

For reference: API was added in PaperMC/Paper#914

Fix implementation of Player.getVirtualHost()/getProtocolVersion()
Right now, Player.getVirtualHost() returns the client's IP address.
However, it is actually supposed to return the hostname/port the
player used to connect to the server.

Correct this and also make use of the version information in
GlowSession instead of just returning the constant.
@CLAassistant

This comment has been minimized.

CLAassistant commented Jan 28, 2018

CLA assistant check
All committers have signed the CLA.

@mastercoms

This comment has been minimized.

Member

mastercoms commented Jan 28, 2018

Does this fix #547?

@Minecrell

This comment has been minimized.

Contributor

Minecrell commented Jan 28, 2018

@mastercoms Not sure, it's not too likely that many public plugins are already using this API (considering it is Paper only) - so probably not.

@Pr0methean Pr0methean merged commit 31f94e2 into GlowstoneMC:dev Jan 28, 2018

2 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

momothereal added a commit that referenced this pull request Feb 4, 2018

Fix implementation of Player.getVirtualHost()/getProtocolVersion() (#824
)

Right now, Player.getVirtualHost() returns the client's IP address.
However, it is actually supposed to return the hostname/port the
player used to connect to the server.

Correct this and also make use of the version information in
GlowSession instead of just returning the constant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment