Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SLF4J logging for plugins #825

Merged
merged 1 commit into from Jan 28, 2018
Merged

Fix SLF4J logging for plugins #825

merged 1 commit into from Jan 28, 2018

Conversation

@Minecrell
Copy link
Contributor

@Minecrell Minecrell commented Jan 28, 2018

SLF4J logging for plugins is a feature introduced in PaperMC/Paper#890. Plugins should be able to use SLF4J as alternative logging API.

All that is necessary to make that work is a proper SLF4J adapter implementation. However, right now Glowstone includes the SLF4J implementation for Log4j 1.x, which isn't used in Glowstone at all. (This was incorrectly added in #612)

Include the correct SLF4J implementation for the java.util.logging API to make SLF4J logging work correctly.

SLF4J logging for plugins is a feature introduced in
PaperMC/Paper#890. Plugins should be able to use SLF4J as
alternative logging API.

All that is necessary to make that work is a proper SLF4J adapter
implementation. However, right now Glowstone includes the SLF4J
implementation for Log4j 1.x, which isn't used in Glowstone at all.

Include the correct SLF4J implementation for the java.util.logging
API to make SLF4J logging work correctly.
@Pr0methean Pr0methean merged commit 8624385 into GlowstoneMC:dev Jan 28, 2018
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details
@Pr0methean
Copy link
Contributor

@Pr0methean Pr0methean commented Jan 28, 2018

Thanks! I wasn't aware of the plugin logging when I wrote #612.

aramperes added a commit that referenced this pull request Feb 4, 2018
SLF4J logging for plugins is a feature introduced in
PaperMC/Paper#890. Plugins should be able to use SLF4J as
alternative logging API.

All that is necessary to make that work is a proper SLF4J adapter
implementation. However, right now Glowstone includes the SLF4J
implementation for Log4j 1.x, which isn't used in Glowstone at all.

Include the correct SLF4J implementation for the java.util.logging
API to make SLF4J logging work correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.