Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Extract first few strings to resource bundle #874

Merged
merged 16 commits into from Mar 25, 2018

Conversation

@Pr0methean
Copy link
Contributor

@Pr0methean Pr0methean commented Mar 20, 2018

This extracts the localizable strings in GlowServer, lines 1-887, into a resource bundle. The rest can be done in a similar manner. Should a naming convention be established for the string keys first?

@aramperes
Copy link
Member

@aramperes aramperes commented Mar 20, 2018

For one, I think there should be a prefix distinction between console output and in-game messages/strings.

e.g. console.info.something-something and game.something-else

Log levels should be prefixed too if the message is strictly related to that level, e.g. warning vs. info.

Also, periods should be there to split prefixes/groups of similar messages, while dashes should be used for multiple words. For example:

console.info.some-feature.enabled=Some feature is enabled.
console.info.some-feature.disabled=Some feature is disabled.

I think we should avoid the use of (conjugated) verbs and use more general terms, e.g. console.warning.proxy-enabled-online-server instead of proxy.support.is.enabled.but.online.mode.is.enabled

@Pr0methean
Copy link
Contributor Author

@Pr0methean Pr0methean commented Mar 23, 2018

@momothereal How do these new message names look?

@mastercoms
Copy link
Member

@mastercoms mastercoms commented Mar 23, 2018

@momothereal does it look good to you?

@Pr0methean Pr0methean requested a review from aramperes Mar 25, 2018
@aramperes aramperes merged commit 33413c9 into GlowstoneMC:dev Mar 25, 2018
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details
@Pr0methean Pr0methean deleted the Pr0methean:i18n branch Mar 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants