Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlowPlayerProfile looks up UUID asynchronously #882

Merged
merged 6 commits into from Mar 27, 2018

Conversation

@Pr0methean
Copy link
Contributor

@Pr0methean Pr0methean commented Mar 26, 2018

Fixes #881. GlowServer.createProfile() now returns immediately, but GlowPlayerProfile.getId() may block if the instance !isComplete() and didn't come from GlowPlayerProfile.getProfile(String name). I've asked @Minecrell to test this change, to determine if the blocking getId() poses a problem in practice.

Pr0methean added 4 commits Mar 26, 2018
Fixes #881. Server.createProfile() now returns immediately, but GlowPlayerProfile.getId() may block.
@mastercoms mastercoms merged commit 3c739bc into GlowstoneMC:dev Mar 27, 2018
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants