New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] 3 nesting levels is enough! #908

Merged
merged 5 commits into from Apr 29, 2018

Conversation

Projects
None yet
4 participants
@Pr0methean
Contributor

Pr0methean commented Apr 29, 2018

This simplifies LocalizedStrings by limiting the nesting depth within it to 3 levels. Excessive nesting bloats the jar file, slows down IDEs, forces very short lines due to the indentation, and makes it harder to find a relevant message. In several cases, a 4th-level sub-interface had the same name (modulo case) as a message, which can't have helped readability.

Pr0methean added some commits Apr 27, 2018

@Pr0methean Pr0methean requested review from smartboyathome and mastercoms Apr 29, 2018

@smartboyathome

Overall, I agree with these changes. We might want to rethink the levels altogether. Was never fully comfortable with the sub-interface thing, but I didn't have any hard data to back up my worries, and it ran fine on my machine.

@momothereal momothereal merged commit 28e0a4b into GlowstoneMC:dev Apr 29, 2018

2 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment