Skip to content

Linkstone runtime support#952

Merged
mastercoms merged 15 commits intoGlowstoneMC:1.12from
aki-ks:linkstone
Jul 1, 2021
Merged

Linkstone runtime support#952
mastercoms merged 15 commits intoGlowstoneMC:1.12from
aki-ks:linkstone

Conversation

@aki-ks
Copy link
Member

@aki-ks aki-ks commented Jul 4, 2018

This PR redirects uses of fields annotated with a @Field annotation to the corresponding getter and setter methods. Regular invokes and reflective accesses will be redirected.

Glowkit#20 must be merged for this PR.

@aki-ks
Copy link
Member Author

aki-ks commented Jul 4, 2018

Linkstone#4 must also be merged and the "annotation" and "runtime" submodules must be published onto a repository.

@WesleyVanNeck
Copy link

what is linkstone ?

@MatrixTunnel
Copy link

This explains it pretty well https://github.com/GlowstoneMC/Linkstone/blob/master/README.md

@aki-ks aki-ks changed the title Linkstone runtime support WIP: Linkstone runtime support Jul 5, 2018
@mastercoms
Copy link
Member

@aki-ks What is the status of this PR? Do you think it could be reviewed for merge in its current state?

@aki-ks
Copy link
Member Author

aki-ks commented Sep 28, 2018

Yes, I think so, but you must first make the linkstone-runtime and linkstone-annotations dependency available to the project (publish it on glowstone's maven repo).

@aki-ks aki-ks changed the title WIP: Linkstone runtime support Linkstone runtime support Sep 28, 2018
@mastercoms
Copy link
Member

This is currently blocked by Linkstone getting a working CircleCI build.

@CLAassistant
Copy link

CLAassistant commented Sep 29, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ mastercoms
❌ aki_ks


aki_ks seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mastercoms mastercoms closed this Jan 16, 2021
@mastercoms mastercoms reopened this Jan 16, 2021
@mastercoms
Copy link
Member

Linkstone is now deployed to our Maven repo, through GitHub Actions, so this PR is no longer blocked.

@mastercoms
Copy link
Member

mastercoms commented Jan 18, 2021

aki-ks has signed the CLA, but the bot does not recognize the slightly renamed username.

@mastercoms mastercoms changed the base branch from dev to 1.12 July 1, 2021 00:43
@mastercoms mastercoms merged commit 275a15e into GlowstoneMC:1.12 Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants