New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Wettest Update (1.13) #957

Open
wants to merge 46 commits into
base: dev
from

Conversation

@mastercoms
Member

mastercoms commented Jul 20, 2018

Glowstone is proud to announce the Update Aquatic (well, Mojang is, we're pretty panicked right now)

Tasks

The big one

The other big one

Feature completeness

So. Many. Features. This list is WIP and will only cover major feature additions/changes. If you are a developer, feel free to edit and add more items and detail to this list. For a comprehensive list of changes, refer to the wiki.

Most features in this list are non-blocking to this PR getting merged, but they'll be nice to implement. However, there are a few things that have to be implemented or else we wouldn't really be 1.13 (mostly just the stuff in the General section below).

General

  • Data packs support

Can I interrupt this list for a second to just say how great data packs are going to be for Glowstone? They solve a ton of issues with us not being able to replicate game data from vanilla. Ok, let's carry on.

  • Tags
  • Where did our IDs go? (also known as "the flattening") (#960)

Blocks

  • Different air types
  • Stripped logs
  • Stripped wood
  • Turtle Egg
  • New water physics behavior

Items

  • Debug stick
  • New recipes TODO
    • Wood block
  • Trident weapon
  • New spawn eggs TODO

World

  • Coral reefs
  • Icebergs
  • Shipwrecks
  • Underwater caves
  • Underwater ruins
  • Kelp
  • Bubble columns
  • Seagrass
  • Sea Pickle
  • Biomes
    • The End
      • Small End Islands
      • End Midlands
      • End Highlands
      • End Barrens
    • Ocean
      • Warm Ocean
      • Lukewarm Ocean
      • Cold Ocean
      • Deep Warm Ocean
      • Deep Lukewarm Ocean
      • Deep Warm Ocean
      • Deep Cold Ocean
      • Deep Frozen Ocean
      • Frozen Ocean
  • Buffet world type

Status Effects/Potions

  • Slow falling
  • Turtle master
  • Status: Conduit Power
  • Status: Dolphin's Grace

Enchantments

  • Channelling
  • Impaling
  • Loyalty
  • Riptide

Commands

  • /bossbar
  • /data
  • /datapack
  • /locate
  • /scoreboard render types hearts and integer added
  • /tp an alias of the new /teleport
  • /time supports setting to noon and midnight

More changes listed here: https://minecraft.gamepedia.com/1.13#Command_format_2

Advancements

Entities

  • Dolphins
  • Drowned
  • Fish TODO
    • Cod
    • Salmon
    • Puffer Fish
    • Tropical Fish
  • Phantoms
  • Turtles
  • Trident (projectile)
@@ -697,9 +697,16 @@ public void setRawLocation(Location location, boolean fall) {
if (hasMoved()) {
if (!fall || type == Material.LADDER // todo: horses are not affected
|| type == Material.VINE // todo: horses are not affected

This comment has been minimized.

@Pr0methean

Pr0methean Aug 13, 2018

Contributor

this instanceof Horse (or some subtype) &&

This comment has been minimized.

@momothereal

momothereal Aug 14, 2018

Member

I'm confused about this todo, does it mean horses should take fall damage even on these blocks, or should be nullified entirely for all horses?

@Override
public boolean isPersistent() {
// TODO: 1.13
throw new UnsupportedOperationException("Not supported yet.");

This comment has been minimized.

@Pr0methean

Pr0methean Aug 13, 2018

Contributor

Just add @Getter @Setter private boolean persistent as a starting point, and move the TODO there.

This comment has been minimized.

@momothereal

momothereal Aug 14, 2018

Member

See the other comment on this

@Override
public boolean isSwimming() {
// TODO: 1.13
throw new UnsupportedOperationException("Not implemented yet.");

This comment has been minimized.

@Pr0methean

Pr0methean Aug 13, 2018

Contributor

Add @Getter @Setter private boolean swimming as a starting point, and move the TODO there.

This comment has been minimized.

@momothereal

momothereal Aug 14, 2018

Member

I'd rather have this error thrown if a plugin uses unimplemented APIs than failing silently. At least then, incompatibility is made clear to the end user.

@@ -277,26 +280,31 @@ private EquipmentSlot getEquipType(Material mat) {
case IRON_HELMET:

This comment has been minimized.

@Pr0methean

Pr0methean Aug 13, 2018

Contributor

What about the turtle-shell helmet?

This comment has been minimized.

@momothereal

momothereal Aug 14, 2018

Member

We should probably group equipment types anyway (or is that already done?). The turtle-shell can be added to such a group.

This comment has been minimized.

@Pr0methean

Pr0methean Aug 15, 2018

Contributor

I'd suggest, during the next change to Glowkit, adding the equipment slot as a field of Material with a getter.

momothereal and others added some commits Aug 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment