Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] 1.13 protocol update #958

Merged
merged 16 commits into from Aug 14, 2018
Merged

[WIP] 1.13 protocol update #958

merged 16 commits into from Aug 14, 2018

Conversation

@aramperes
Copy link
Member

@aramperes aramperes commented Jul 22, 2018

WIP branch for 1.13 protocol compatibility.

See #957 for full 1.13 update progress

@mastercoms mastercoms mentioned this pull request Jul 22, 2018
0 of 67 tasks complete
writeChat(buf, (TextMessage) value);
break;
case OPTCHAT:
writeChat(buf, (TextMessage) value);

This comment has been minimized.

@Pr0methean

Pr0methean Aug 1, 2018
Contributor

Missing a break. Merge with previous case.

This comment has been minimized.

This comment has been minimized.

@mastercoms

mastercoms Aug 23, 2019
Member

What are you question marking?

@aramperes aramperes dismissed Pr0methean’s stale review Aug 5, 2018

Not ready for approval, review changes applied

@aramperes aramperes merged commit 9d460cf into 1.13 Aug 14, 2018
1 of 2 checks passed
1 of 2 checks passed
ci/circleci: build Your tests failed on CircleCI
Details
license/cla Contributor License Agreement is signed.
Details
@aramperes aramperes deleted the wip/1.13/protocol branch Aug 14, 2018
@mastercoms mastercoms mentioned this pull request May 6, 2020
0 of 67 tasks complete
@mastercoms mastercoms mentioned this pull request Dec 26, 2020
0 of 67 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.