Fixes Guardian/ElderGuardian API #968 #970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aramperes
requested changes
Oct 21, 2018
| @Override | ||
| public void save(GlowElderGuardian entity, CompoundTag compound) { | ||
| super.save(entity, compound); | ||
| compound.putBool("Elder", true); |
There was a problem hiding this comment.
The Elder tag has been removed from both guardian and elder_guardian stores, so it is no longer necessary to save it.
|
Hey @j1o1h1n, apologies for the delay. Could you merge this repo's |
aramperes
approved these changes
Nov 7, 2018
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up from #046673f by @Pr0methean to fix #968
setElderis all inGlowGuardian, and works for both classesElderGuardianStore, using the single GuardianStore for both didn't work out wellStore.load