Use resolved UUID instead of illegal string. #979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
crashdemons
added a commit
to crashdemons/PlayerHeads
that referenced
this pull request
Nov 18, 2018
…MC/Glowstone#977 and GlowstoneMC/Glowstone#979 being resolved. Older servers cannot be supported.
aramperes
approved these changes
Nov 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference #977 #978
PR #978 attempted to fix Issue #977 (Completablefuture typename was being used as the UUID string in NBT data), however after the null check, the uuid variable that was resolved is discarded instead of used in the NBT.
This change uses the resolved UUID in the NBT instead of the CompletableFuture type-string as the uuid.
In #977 I list some exceptions that occur when this string is read before adding this PR. After adding this PR, these don't seem to appear.
EDIT: double word