Command localization, step 1 #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pr0methean
changed the title
aramperes
approved these changes
Dec 16, 2018
mastercoms
previously requested changes
Dec 17, 2018
src/main/java/net/glowstone/command/minecraft/GlowVanillaCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/net/glowstone/command/minecraft/GlowVanillaCommand.java
Outdated
Show resolved
Hide resolved
Pr0methean
dismissed
mastercoms’s stale review
Resolved; will request another round
|
Thank you for your contribution to Glowstone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates an abstract base class for commands which extend VanillaCommand and need i18n, so they will speak to players in their own locale if available. (To non-player CommandSender instances, they'll speak the server locale.)
Subsequent PRs will do the same for BukkitCommand, make all the concrete command classes extend these two, and add tests to ensure no missing or unused entries in
commands.properties.