Localize BanCommand #987
Merged
Localize BanCommand #987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also handle null locale string.
Also makes a few tweaks necessary for implementations of GlowVanillaCommand. For example, LocalizedStringImpl is now public so that commands can make them use the client's ResourceBundle.
This reverts commit 7a3ad7c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This localizes BanCommand and also demonstrates how localized commands can work. Since each CommandSender has a different ResourceBundle, all LocalizedStringImpl instances a command uses must be created on demand, and thus LocalizedStringsTest's approach isn't applicable here.