Localize /ban, /ban-ip, /banlist, /clear #988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastercoms
previously requested changes
Dec 25, 2018
src/main/java/net/glowstone/command/minecraft/ClearCommand.java
Outdated
Show resolved
Hide resolved
mastercoms
approved these changes
Dec 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Localizes 4 more commands. Refactors sendInColor to put the color parameter first. Replaces several command-specific messages with a new generic "no such player" message to save L10n effort and allow object reuse; this can be done in future with other shared messages as well. Tests that description and usage messages exist in CommandTest if the command under test extends GlowVanillaCommand. (Once they all do, this condition will be removed.)