New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ResourceTypes endpoint #33

Closed
jgomer2001 opened this Issue Sep 26, 2017 · 3 comments

Comments

Projects
None yet
1 participant
@jgomer2001
Collaborator

jgomer2001 commented Sep 26, 2017

Current impl of /resourceType endpoint is receiving an Authorization header as parameter. Authorization is not needed in this case.

Additionally from section 4 of RFC 7644:

If a "filter" is provided, the service provider SHOULD respond with HTTP status code 403 (Forbidden) to ensure that clients cannot incorrectly assume that any matching conditions specified in a filter are true.

We should add this check. Also, removing redundant code there would be good.

@jgomer2001 jgomer2001 self-assigned this Sep 26, 2017

@jgomer2001

This comment has been minimized.

Collaborator

jgomer2001 commented Sep 27, 2017

Some updates applied https://github.com/GluuFederation/oxTrust/blob/scim2_compliance/server/src/main/java/org/gluu/oxtrust/ws/rs/scim2/ResourceTypeWS.java#L30

Need to add methods for all resource types except User.

Still missing the filter check

@jgomer2001 jgomer2001 added this to the CE 3.2 milestone Sep 27, 2017

jgomer2001 added a commit to GluuFederation/oxTrust that referenced this issue Oct 2, 2017

@jgomer2001

This comment has been minimized.

Collaborator

jgomer2001 commented Oct 16, 2017

Done ResourceTypeWS.

Pending test cases for closing issue

@jgomer2001

This comment has been minimized.

Collaborator

jgomer2001 commented Oct 23, 2017

Test ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment