New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groups endpoint allows writing non-existing members #43

Closed
jgomer2001 opened this Issue Oct 23, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@jgomer2001
Collaborator

jgomer2001 commented Oct 23, 2017

When creating a group one might supply any string in the members.value attribute, and the implementation does not validate data coming are REAL user LDAP inums, thus degenerating in LDAP groups whose members attribute contain wrong information.

Example:

If supplying

{
  "schemas": [ "urn:ietf:params:scim:schemas:core:2.0:Group" ],
  "displayName": "scim_test_worldowners"
  "members":[
  	{value: "GIBBERISH"}
  ]
}

The result in ldap is:

dn: inum=...,ou=groups,o=...,o=gluu
objectClass: top
objectClass: gluuGroup
inum: ...
gluuStatus: active
displayName: scim_test_worldowners
member: inum=GIBBERISH,ou=people,o=...,o=gluu

See https://github.com/GluuFederation/oxTrust/blob/version_3.1.1/server/src/main/java/org/gluu/oxtrust/util/CopyUtils2.java#L1236-L1236

@jgomer2001 jgomer2001 added the bug label Oct 23, 2017

@jgomer2001 jgomer2001 added this to the CE 3.2 milestone Oct 23, 2017

@jgomer2001 jgomer2001 self-assigned this Oct 23, 2017

@jgomer2001

This comment has been minimized.

Collaborator

jgomer2001 commented Nov 12, 2017

Check added in working branch

@jgomer2001 jgomer2001 closed this Nov 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment