New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong modeling of SearchRequest and its schema #59

Closed
jgomer2001 opened this Issue Nov 27, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@jgomer2001
Collaborator

jgomer2001 commented Nov 27, 2017

SearchRequest class does not model the attributes param correctly. According to spec this should be a (multi-valued) string list - section 3.4.3 RFC 7644. Currently, it's being used as a comma-separated string.

Additionally, the name used for serialization/deserialization is not correct (member is named attributesArray).

The value Constants.SEARCH_REQUEST_SCHEMA_ID used to specify the schema is wrong as well (mis-spelled). Current value is urn:ietf:params:scim:schemas:core:2.0:SearchRequest while it should be urn:ietf:params:scim:api:messages:2.0:SearchRequest.

In other words, the POST search is using a payload that is not spec compliant.

@jgomer2001 jgomer2001 added this to the CE 3.2 milestone Nov 27, 2017

@jgomer2001 jgomer2001 self-assigned this Nov 27, 2017

jgomer2001 added a commit to GluuFederation/oxTrust that referenced this issue Dec 8, 2017

@jgomer2001 jgomer2001 closed this Dec 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment