New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow searching with startindex values higher than max_count #69

Closed
syntrydy opened this Issue Mar 19, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@syntrydy

syntrydy commented Mar 19, 2018

Problem context found in this ticket.

@syntrydy syntrydy changed the title from Search result isn't accurate for startindex > 1 to Search results count isn't accurate when startindex > 1 Mar 19, 2018

@willow9886 willow9886 added this to the 3.1.4 milestone Jun 18, 2018

@jgomer2001 jgomer2001 changed the title from Search results count isn't accurate when startindex > 1 to Allow searching with startindex values higher than max_count Jul 17, 2018

@jgomer2001 jgomer2001 added the bug label Jul 17, 2018

@jgomer2001

This comment has been minimized.

Collaborator

jgomer2001 commented Jul 17, 2018

The searching functionality was not implemented propertly. It just run a search capped at max_count items, and then took the slice [startCount - 1, startCount - 1 + count)

Proper solution is to scroll through different LDAP result pages in a way that max_count does not impose any restriction on where the required results start at, thus avoiding increasing max_count to impractical high values.

jgomer2001 added a commit to GluuFederation/oxTrust that referenced this issue Jul 17, 2018

jgomer2001 added a commit to GluuFederation/oxTrust that referenced this issue Jul 17, 2018

jgomer2001 added a commit to GluuFederation/oxCore that referenced this issue Jul 17, 2018

jgomer2001 added a commit to GluuFederation/oxCore that referenced this issue Jul 17, 2018

@jgomer2001

This comment has been minimized.

Collaborator

jgomer2001 commented Jul 17, 2018

In this issue max_count had been increased. With the current fix, there is no need for that. I have reverted again to 200.

max_count should be set to any value that users consider could be the upper bound for the count parameter of SCIM searches. In practice this may be less than 200 actually.

GluuFederation/community-edition-setup@ed44ad3
GluuFederation/community-edition-setup@230db73

@jgomer2001 jgomer2001 closed this Jul 17, 2018

jgomer2001 added a commit that referenced this issue Jul 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment