New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename uma_client_authz_rpt_policy to scim_access_policy #444

Closed
nynymike opened this Issue Jun 25, 2018 · 7 comments

Comments

Projects
None yet
5 participants
@nynymike
Contributor

nynymike commented Jun 25, 2018

The name of the default policy for scope SCIM Access is uma_client_authz_rpt_policy

A better name for this policy would be scim_access_policy

I think we just need to update the ldif for the interception script and the UMA scope.

@nynymike nynymike added this to the 3.1.4 milestone Jun 25, 2018

@mbaser mbaser closed this in 5c9d6a0 Jun 25, 2018

@sahiliamsso

This comment has been minimized.

Contributor

sahiliamsso commented Aug 15, 2018

image
dont see changes in the latest war file

@sahiliamsso sahiliamsso reopened this Aug 15, 2018

mbaser added a commit that referenced this issue Aug 16, 2018

@jgomer2001

This comment has been minimized.

Contributor

jgomer2001 commented Aug 22, 2018

@nynymike uma_client_authz_rpt_policy is used by both SCIM and passport...

@mbaser

This comment has been minimized.

Collaborator

mbaser commented Aug 26, 2018

@jgomer2001 what is your suggestion?

@jgomer2001

This comment has been minimized.

Contributor

jgomer2001 commented Aug 27, 2018

This policy grants access based on a predefined list of client IDs set in config property of the cust script. If the client involved in the call is part of the list, access is simply granted…

So it's a generic script not tied to particular usage. IMO, original name uma_client_authz_rpt_policy is good since it fits well to what it actually does

@afroDC

This comment has been minimized.

Contributor

afroDC commented Aug 27, 2018

I agree with @jgomer2001 . Should we change this scripts name if it does more than just SCIM, @nynymike ?

@nynymike

This comment has been minimized.

Contributor

nynymike commented Aug 27, 2018

scim_access_policy would be more descriptive. No need for my +1 on stuff like this :-)

@afroDC

This comment has been minimized.

Contributor

afroDC commented Aug 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment