New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passport should return non zero exit code on startup errors #11

Closed
yurem opened this Issue Apr 10, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@yurem
Contributor

yurem commented Apr 10, 2018

When passport start fail due to error like:

2018-04-10T04:30:30+0000 [INFO] UMAConfigurations were received
2018-04-10T04:30:30+0000 [ERROR] Error in starting the server. error:-  https://u144.gluu.info/oxauth/restv1/token

It should return no zero exit code to notify startup script

@yurem yurem added this to the 3.1.4 milestone Apr 10, 2018

@jgomer2001

This comment has been minimized.

Contributor

jgomer2001 commented May 29, 2018

According to the timer added in #12, the service is always running (always doing attempts to obtain the configuration), so it won't report any startup errors.

@jgomer2001 jgomer2001 closed this Aug 6, 2018

@natt-tester

This comment has been minimized.

natt-tester commented Aug 15, 2018

Tested in 3.1.4 + Ubuntu 3.1.4 + Firefox. If I'm testing it correctly, I think it still needs improvement -- the error code command shows 0 after restarting passport, but the logs show one repeated error:

starting_passport

passport_error

After running npm install, there are no more errors, only the info:

deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment