New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework flow and unify custom scripts #38

Closed
jgomer2001 opened this Issue Jun 19, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@jgomer2001
Contributor

jgomer2001 commented Jun 19, 2018

Currently passportexternalauthenticator.py and samlpassportauthenticator.py are almost identical.
Flows (https://gluu.org/docs/ce/authn-guide/inbound-saml-passport/#sequence-diagram and https://github.com/GluuFederation/gluu-passport#sequence-diagram) are similar as well.

The prepareForStep method needs work and has brought a lot of confusion. See also GluuFederation/oxAuth#816

@jgomer2001

This comment has been minimized.

Contributor

jgomer2001 commented Jul 5, 2018

Summary of the solution is described here, section "flow"

@jgomer2001 jgomer2001 closed this Jul 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment