Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sub from Userinfo response for password grant clients #1325

Closed
nynymike opened this issue Apr 22, 2020 · 3 comments
Closed

Remove sub from Userinfo response for password grant clients #1325

nynymike opened this issue Apr 22, 2020 · 3 comments
Assignees
Labels
bug bug in code
Milestone

Comments

@nynymike
Copy link
Contributor

There is no point to a pairwise sub claim for clients using the password grant. The client already has a username, which can be correlated. Just return the username as the sub value.

@nynymike nynymike added the bug bug in code label Apr 22, 2020
@nynymike nynymike added this to the 4.2 milestone Apr 22, 2020
uprightech added a commit that referenced this issue Apr 30, 2020
  * Fixes for issue #1325
@uprightech
Copy link
Collaborator

@nynymike , can we close this too ?

@yuriyz
Copy link
Contributor

yuriyz commented May 1, 2020

Code in user info is a bit outdated, sub value construction is centralized in grant.getSub(). Corrected it in 5d9b11b

Closing ticket.
@uprightech PR instead of direct commit would be better so we can catch such kind of improvements in first place.

@yuriyz yuriyz closed this as completed May 1, 2020
@uprightech
Copy link
Collaborator

Sorry , my bad , I realized I commited to the main repo instead of a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bug in code
Projects
None yet
Development

No branches or pull requests

3 participants