New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove code duplication #195

Open
yuriyz opened this Issue Mar 29, 2016 · 1 comment

Comments

Projects
None yet
4 participants
@yuriyz
Contributor

yuriyz commented Mar 29, 2016

There are number of places where we have code duplication especially in tests. We have to avoid this error prone approach. 15 or 16 duplications indeed must be fixed.

codeduplication

This can be the starting point.
https://github.com/GluuFederation/oxAuth/blob/18f314421cc62b85d0ce064fd0e8f5d815f7b074/Client/src/test/java/org/xdi/oxauth/client/Asserter.java

However maybe it makes sense to really start very small test framework to avoid code duplication and as result increase stability of our tests.

@yuriyz yuriyz added this to the CE 2.4.4 milestone Mar 29, 2016

@yurem yurem modified the milestones: CE 2.4.5, CE 2.4.4 Jul 14, 2016

@nynymike nynymike modified the milestones: CE 3.1.0, CE 3.0.0 Nov 29, 2016

@willow9886

This comment has been minimized.

Contributor

willow9886 commented Apr 10, 2017

@worm333 maybe you can take a look at this?

@yurem yurem modified the milestones: CE 3.1.0, CE 3.1.1 Sep 7, 2017

@yurem yurem modified the milestones: CE 3.1.1, CE 3.1.2 Sep 26, 2017

@willow9886 willow9886 modified the milestones: CE 3.1.2, CE 3.2.0 Nov 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment