New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client resets grant-types if it has no value #602

Open
centroxy opened this Issue Aug 5, 2017 · 5 comments

Comments

Projects
None yet
6 participants
@centroxy

centroxy commented Aug 5, 2017

Currently client application has to pass grant-types to Update client method. If not passed it resets the value from the value provided during "setup client" to default value.

But in update client method, application should send those values user want to update

@yurem yurem added this to the CE 3.1.2 milestone Oct 9, 2017

@willow9886

This comment has been minimized.

Contributor

willow9886 commented Nov 3, 2017

@centroxy what do you mean by "update client method" ? Is this when you call the client registration api or via the oxTrust GUI?

@centroxy

This comment has been minimized.

centroxy commented Nov 4, 2017

@willow9886 I am using update-site-registration method (oxd server) . This command should only update the fields I want to update using update-site-registration . It should not reset other fields like grant-types

@yuriyz

This comment has been minimized.

Contributor

yuriyz commented Nov 4, 2017

grant_types are changed based on response_types. It is coded by Javier in client registration service. I guess the way it works now is consistent because we reflect valid grant type based on response type. I think Javier can give more thoughts here.

@nynymike

This comment has been minimized.

Contributor

nynymike commented Nov 5, 2017

I agree with Jajati.

@qbert2k

This comment has been minimized.

Contributor

qbert2k commented Nov 6, 2017

Hello @centroxy, depending on the registration params: response_types and grant_types, oxAuth will automatically add the corresponding params to make consistent as @yuriyz said.

For example:
If you send response_types=code then the param grant_types=authorization_code will be added automatically.
If you send response_types=code+id_token then the param grant_types=authorization_code+ implicit will be added automatically.

http://openid.net/specs/openid-connect-registration-1_0.html#ClientMetadata

@yurem yurem modified the milestones: CE 3.1.2, CE 3.2.0 Nov 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment