Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth Scope Refactoring #756

Closed
nynymike opened this issue Feb 25, 2018 · 2 comments

Comments

@nynymike
Copy link
Contributor

commented Feb 25, 2018

We should combine all scopes under ou=scopes,o=(org-inum),o=gluu

The current implementation results in an Inconsistent primary key--for OpenID scopes, the primary key is 'displayName'... in UMA scopes the primary key is oxID.

displayName should not be the primary key for the scope... this is contrary to the meaning of the attribute's name, which implies that it is for display purposes only. OpenID scopes should probably move to oxID as the primary key.

  • We should use objectclass oxAuthCustomScope for all scopes--or even better would is just oxAuthScope.
  • objectclass oxAuthUmaScopeDescription does not have that many attributes... we should just add them to oxAuthCustomScope
  • oxTrust can exclude oxScopeType=UMA when displaying OpenID Connect clients
  • We should require oxID uniqueness. Within a domain, scope X should be unique.
  • We need to make a todo item for 3.1 --> 3.2 migration... this is a non-backwards compatible change. Entries under ou=scopes,o=uma,o=(org-inum),o=gluu will need to be migrated.

@nynymike nynymike added this to the 3.2.0 milestone Feb 25, 2018

@yuriyz

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

Summary of persistence changes (cc: @mbaser ):

renamed attribute: oxPolicyScriptDn -> oxUmaPolicyScriptDn
removed OC: oxAuthUmaScopeDescription 
oxAuthCustomScope OC is extended by  "oxId", "oxIconUrl", "oxUmaPolicyScriptDn" attributes (oxAuthCustomScope replaces oxAuthUmaScopeDescription).
UMA scope removed attributes: owner, oxRevision.
Added oxScopeType: uma

yuriyz added a commit to GluuFederation/community-edition-setup that referenced this issue Apr 26, 2019

yuriyz added a commit that referenced this issue Apr 26, 2019

oxauth : performed OAuth Scope Refactoring:
- identify scopes by `oxId` (not `displayName`)
- removed oxAuthUmaScopeDescription
- oxAuthUmaScopeDescription replaced by oxAuthCustomScope

#756

yuriyz added a commit to GluuFederation/community-edition-setup that referenced this issue Apr 27, 2019

@yuriyz

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019

done in master branch (4.0)

@yuriyz yuriyz closed this May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.