New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User should be redirect to error page instead of login when an exception occurs during external authentication #796

Closed
syntrydy opened this Issue Apr 25, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@syntrydy
Contributor

syntrydy commented Apr 25, 2018

Description

Currently user is redirected to login page when exception occurs during external authentication.
Normally, user should be redirected to error page.

  public String executeExternalGetPageForStep(CustomScriptConfiguration customScriptConfiguration, int step) {
        try {
            log.debug("Executing python 'getPageForStep' authenticator method");
            PersonAuthenticationType externalAuthenticator = (PersonAuthenticationType) customScriptConfiguration.getExternalType();
            Map<String, SimpleCustomProperty> configurationAttributes = customScriptConfiguration.getConfigurationAttributes();
            return externalAuthenticator.getPageForStep(configurationAttributes, step);
        } catch (Exception ex) {
            log.error(ex.getMessage(), ex);
        }

        return null;
    }

https://github.com/GluuFederation/oxAuth/blob/master/Server/src/main/java/org/xdi/oxauth/auth/Authenticator.java#L324

@mzico

This comment has been minimized.

Contributor

mzico commented Apr 26, 2018

@yurem @syntrydy : Do you think it's possible to patch 2.4.4 sp3 ? We need that for one customer's production.

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Apr 26, 2018

For me yes, since the adjustment we have to do don't have touch their custom custom code. We can provide a patch.

Currently this customer need the patch .

@yurem yurem added this to the 3.1.4 milestone Apr 26, 2018

@syntrydy syntrydy self-assigned this May 16, 2018

syntrydy pushed a commit that referenced this issue May 16, 2018

syntrydy added a commit that referenced this issue May 16, 2018

syntrydy pushed a commit that referenced this issue May 16, 2018

syntrydy added a commit that referenced this issue May 16, 2018

@yurem

This comment has been minimized.

Contributor

yurem commented Aug 14, 2018

Fixed

@yurem yurem closed this Aug 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment