New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax log level when claims gathering script name is blank #798

Closed
jgomer2001 opened this Issue Apr 26, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@jgomer2001
Contributor

jgomer2001 commented Apr 26, 2018

In UMA, when the corresponding authz script returns an empty name in getClaimsGatheringScriptName method, we are logging an error statement.

Some users getting confused with this error when the interactive claims gathering does not apply as in the case of SCIM or passport (see this support ticket for more contextual info).

Can we use warn there?

The ticket points out something interesting about no errors appearing if the method simply returns an arbitrary string?. Can you verify this is so?

@yuriyz

This comment has been minimized.

Contributor

yuriyz commented Apr 26, 2018

@jgomer2001 'getClaimsGatheringScriptName' returns script name which will be invoked when need_info error is returned. It means that it is runtime information. If we have situation when we don't neeed claims gathering maybe we can introduce constant, like 'NO_SCRIPT' which makes it very verbose to end-user that no claims gathering is involved. What do you think?

@jgomer2001

This comment has been minimized.

Contributor

jgomer2001 commented Apr 26, 2018

I agree, it's a more expressive way

yuriyz added a commit that referenced this issue May 12, 2018

yuriyz added a commit that referenced this issue May 12, 2018

#798 : UMA 2 : introduced no_script constant for cases when claims-ga…
…thering is completely skipped.

(cherry picked from commit c734abd)
@yuriyz

This comment has been minimized.

Contributor

yuriyz commented May 12, 2018

Done for 3.1.4 amd master. Added 'no_script' check. It is possible to return this value inlined or otherwise constant from 'UmaConstants'.

@yuriyz yuriyz closed this May 12, 2018

@yuriyz yuriyz removed the question label May 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment