New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If custom script getPageForStep throws error Authenticator shoudl redirect to error page #799

Closed
yurem opened this Issue Apr 26, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@yurem
Contributor

yurem commented Apr 26, 2018

According to current code Authenticator redirects to login page instead of error page on getPageForStep method execution error:

    public String executeExternalGetPageForStep(CustomScriptConfiguration customScriptConfiguration, int step) {
        try {
            log.debug("Executing python 'getPageForStep' authenticator method");
            PersonAuthenticationType externalAuthenticator = (PersonAuthenticationType) customScriptConfiguration.getExternalType();
            Map<String, SimpleCustomProperty> configurationAttributes = customScriptConfiguration.getConfigurationAttributes();
            return externalAuthenticator.getPageForStep(configurationAttributes, step);
        } catch (Exception ex) {
            log.error(ex.getMessage(), ex);
        }

        return null;
    }

It should redirect to erorr page.

We also need to check if other script which provides page has sum issue.

@yurem yurem added this to the 3.1.4 milestone Apr 26, 2018

@yurem yurem self-assigned this Apr 26, 2018

@yurem

This comment has been minimized.

Contributor

yurem commented Apr 26, 2018

issue #796 already exists

@yurem yurem closed this Apr 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment