New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CleanupTimer has to run in own connection pool to not effect oxauth performance #813

Open
yuriyz opened this Issue May 22, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@yuriyz
Contributor

yuriyz commented May 22, 2018

@yuriyz yuriyz added this to the 3.2.0 milestone May 22, 2018

@yuriyz

This comment has been minimized.

Contributor

yuriyz commented Oct 31, 2018

We have to unify objects that can be cleaned up. Clean up itself can be performed by oxauth or by external application/script (scheduled by cron).

Object that is deletable by cleaner should have :

  • oxAuthExpiration - date when object should be considered as expired (the number of milliseconds since January 1, 1970, 00:00:00 GMT)
  • oxDeletable - boolean flag true/false. If false clean up job should not delete the object.

Filter should look as:
&(oxAuthExpiration<=now)(oxDeletable=true)).

By default oxauth clean timer is turned on however it should be possible to turn it off (for cases when we wish to process it by external script or node in clustered environment).

  • cleanServiceEnabled - boolean attribute with true value by default.
  • cleanServiceInterval - clean up service interval.

Clean service should run queries with separate connection pool.

TODO:

  • check all clean service code and identify objects that does not use oxAuthExpiration attribute
  • make all clean up code work via oxAuthExpiration
  • add oxDeletable and update filters.
  • check how it should work with couchbase.
  • introduce cleanServiceEnabled configuration property
  • introduce clean up connection pool (with separate configuration properties)
@nynymike

This comment has been minimized.

Contributor

nynymike commented Oct 31, 2018

I like it!

@yuriyz yuriyz self-assigned this Oct 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment