New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the prepareForStep method of passport social script #816

Closed
syntrydy opened this Issue May 25, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@syntrydy
Contributor

syntrydy commented May 25, 2018

Description

Currently the method prepareForStep of passport script seems useless.

That method is https://github.com/GluuFederation/oxAuth/blob/version_3.1.4/Server/integrations/passport/PassportExternalAuthenticator.py#L277

  1. It return true even in case of error
  2. The execution of that method always throw an exception on the third line after the try catch block
  3. Removing the try catch block of that method, the passport social works Well
@jgomer2001

This comment has been minimized.

Contributor

jgomer2001 commented Jun 19, 2018

You are right, that prepareForStep is trying to do a flow similar to saml one

but the social should be like this, which is actually implemented doing web browser redirects (for instance see function idp_redirect in passportlogin.xhtml). That's why it works despite the script crashes.

I added this issue as an attempt to rework the flow and consolidate saml/social into a single script if possible.

@jgomer2001 jgomer2001 closed this Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment