New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded code from passport page #821

Closed
yurem opened this Issue Jun 6, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@yurem
Contributor

yurem commented Jun 6, 2018

We have this problematic line. I think instead of checking if there are only hard-coded methods it should just check if this is idp provide and use for it specif redirect url.

Also we can't use hard-coded image names here. I think strategy should have optional field to specify image name/path.

There is more information about this in issue.

@jgomer2001

This comment has been minimized.

Contributor

jgomer2001 commented Jun 19, 2018

@jgomer2001 jgomer2001 closed this Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment