New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better handling for session expired events #875

Closed
willow9886 opened this Issue Aug 25, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@willow9886
Contributor

willow9886 commented Aug 25, 2018

When an oxAuth session expires, the server should take action and display a page that explains the situation to the user (similar to Google example shown below).

Currently when the session expires, it's only clear to the user after they try to sign in. And they get taken to a pretty unhelpful Error Encountered page.

Our improvement should save the user a round trip by explicitly telling them when their session has expired. Some javascript to present this page (so no reload necessary) is ideal.

image

@willow9886 willow9886 added this to the 3.1.5 milestone Sep 12, 2018

@willow9886 willow9886 changed the title from Add handling for session expired events to Add better handling for session expired events Sep 12, 2018

syntrydy pushed a commit that referenced this issue Sep 15, 2018

syntrydy added a commit that referenced this issue Sep 15, 2018

Merge pull request #903 from /issues/875
Ox auth/issues/875

syntrydy pushed a commit that referenced this issue Sep 15, 2018

@yurem yurem modified the milestones: 3.1.5, 3.1.4 Sep 19, 2018

@yurem

This comment has been minimized.

Contributor

yurem commented Sep 19, 2018

screenshot 2
This is how this page looks like after @syntrydy and my changes

@yurem yurem closed this Sep 19, 2018

@willow9886

This comment has been minimized.

Contributor

willow9886 commented Sep 19, 2018

@yurem this doesn't address the issue. The page looks better, but is not an improvement in the user experience for expired sessions. @syntrydy can you please add additional details about implementation, which we had discussed?

@willow9886 willow9886 reopened this Sep 19, 2018

@willow9886

This comment has been minimized.

Contributor

willow9886 commented Sep 19, 2018

OK, we're going to address this issue further via this new issue marked for next version: #906

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment