Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super Gluu created time needs time zone support #901

Closed
nynymike opened this issue Sep 13, 2018 · 2 comments

Comments

@nynymike
Copy link
Contributor

commented Sep 13, 2018

The time zone of the server might be different from the time zone of the subject. For this reason, the server needs to specify the timezone in the QR code "created" field. See line 352:

https://github.com/GluuFederation/oxAuth/blob/master/Server/integrations/super_gluu/SuperGluuExternalAuthenticator.py#L352

Probably best to use the same time zone, like iat

iat
      REQUIRED. Time at which the JWT was issued. Its value is a JSON 
      number representing the number of seconds from 1970-01-01T0:0:0Z
      as measured in UTC until the date/time.

@nynymike nynymike added the bug label Sep 13, 2018

@nynymike nynymike added this to the 4.0 milestone Sep 13, 2018

@corriganjeff

This comment has been minimized.

Copy link

commented Oct 5, 2018

You guys may come up with a different solution but here was my fix for the immediate need:
Install pip's pytz
in the script:
import pytz
then down where the mt_auth_request_dictionary is build:

        .....
        pytztime = pytz.utc.localize(datetime.datetime.utcnow())
        .....
            mt_auth_request_dictionary = {
                                "aud": client_id,
                                "state": session_id,
                                "created": pytztime.strftime('%Y-%m-%dT%H:%M:%S%z'),
        .....

which in the qr code results give the following value:

{
....
,"created":"2018-10-01T16:33:47+0000"
....
}

This would require adding/including pytz to the chroot during install.

@yurem

This comment has been minimized.

Copy link
Contributor

commented Feb 6, 2019

Fixed

@yurem yurem closed this Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.