New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oxauth-client should re-throw connection exception, so client app can handle it #954

Closed
yuriyz opened this Issue Nov 27, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@yuriyz
Contributor

yuriyz commented Nov 27, 2018

Right now oxauth client catch all exceptions and returns null, which does not allow to handle exception by oxd

@yuriyz yuriyz added the enhancement label Nov 27, 2018

@yuriyz yuriyz added this to the 3.1.5 milestone Nov 27, 2018

@yuriyz yuriyz self-assigned this Nov 27, 2018

yuriyz added a commit that referenced this issue Nov 27, 2018

#954 : allowed client apps (like oxd) handle SSL/IO exceptions if it …
…occured during discovery fetching by oxauth-client.

                                                   #954

yuriyz added a commit that referenced this issue Nov 27, 2018

#954 (4.0): allowed client apps (like oxd) handle SSL/IO exceptions i…
…f it occured during discovery fetching by oxauth-client.

                                                   #954

(cherry picked from commit e8ccee8)
@yuriyz

This comment has been minimized.

Contributor

yuriyz commented Nov 27, 2018

done in 3.1.5 and master

@yuriyz yuriyz closed this Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment