New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Button Locations in OpenID Connect Client Configuration #1011

Closed
afroDC opened this Issue Jun 13, 2018 · 7 comments

Comments

Projects
None yet
5 participants
@afroDC

afroDC commented Jun 13, 2018

Currently the buttons for configuration settings like Add Scope are all mashed together at the bottom of the page. This doesn't work well intuitively and is a hindrance when configuring clients. See below:

gluu_openidc_client_buttons

The buttons should be under the corresponding field they're populating:

gluu_openidc_client_page
Also the Default requested Authentication Context Class Reference values: field description should read Default requested Authentication Context Class Refernce (ACR) values: for clarity.

@afroDC afroDC added the enhancement label Jun 13, 2018

@afroDC afroDC added this to the 3.1.4 milestone Jun 13, 2018

@willow9886

This comment has been minimized.

Contributor

willow9886 commented Jun 13, 2018

@shekhar16 please use your best judgement for implementing this in a user friendly way... that means spacing should be visually pleasing, design should be responsive, popups should function well, etc.

@shekhar16

This comment has been minimized.

Contributor

shekhar16 commented Jun 16, 2018

image

@natt-tester

This comment has been minimized.

natt-tester commented Aug 10, 2018

@shekhar16 Please check if the commit has been merged to 3.1.4. I have just checked dev6 with a new war and the buttons are still mashed together:

2018-08-10_19h38_25

@natt-tester natt-tester reopened this Aug 10, 2018

@afroDC

This comment has been minimized.

afroDC commented Aug 10, 2018

They definitely didn't make it into the 3.1.4 repo. Please take care of this @shekhar16

@shekhar16

This comment has been minimized.

Contributor

shekhar16 commented Aug 15, 2018

@natt-tester @afroDC yes it is not merged in any of our main branch in repo. Let me check with Yuriy

yurem added a commit that referenced this issue Aug 15, 2018

Merge pull request #1101 from GluuFederation/#1011
#1011 : moved the buttons to there respective fields.

@natt-tester natt-tester self-assigned this Aug 16, 2018

@yurem

This comment has been minimized.

Contributor

yurem commented Aug 22, 2018

screenshot 3

@yurem

This comment has been minimized.

Contributor

yurem commented Aug 22, 2018

In latest CE 3.1.4 it looks better. I'm closing this issue. Please, reopen it if needed

@yurem yurem closed this Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment