New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New redis configuration ssl parameters support #1018

Closed
yuriyz opened this Issue Jun 22, 2018 · 14 comments

Comments

Projects
None yet
5 participants
@yuriyz
Contributor

yuriyz commented Jun 22, 2018

Now on oxcore we have two more properties for SSL support:

  • useSsl
  • useTrustStoreFilePath.

See class here https://github.com/GluuFederation/oxCore/blob/5437b4200076eef81f43fa19e63989f1b8acbd43/oxService/src/main/java/org/xdi/service/cache/RedisConfiguration.java#L11

We need to support them on UI.

@yuriyz yuriyz added the enhancement label Jun 22, 2018

@yuriyz yuriyz added this to the 3.1.4 milestone Jun 22, 2018

@yuriyz

This comment has been minimized.

Contributor

yuriyz commented Jun 22, 2018

@afroDC

This comment has been minimized.

afroDC commented Jun 22, 2018

Once implemented and 3.1.4 packages go out for testing, I'll check functionality.

@shekhar16

This comment has been minimized.

Contributor

shekhar16 commented Jun 24, 2018

image

@shekhar16

This comment has been minimized.

Contributor

shekhar16 commented Jun 24, 2018

@yuriyz Please check it and let me know if you need anything more in this issue?

@yuriyz

This comment has been minimized.

Contributor

yuriyz commented Jun 24, 2018

looks good, one small improvement, when useSsl=false, set sslTrustStoreFilePath field disabled.

@afroDC

This comment has been minimized.

afroDC commented Jun 25, 2018

@shekhar16 I think we should change useSsl to useSSL.

yurem added a commit that referenced this issue Jul 4, 2018

Merge pull request #1019 from GluuFederation/#1018
#1018 : New redis configuration ssl parameters support
@shekhar16

This comment has been minimized.

Contributor

shekhar16 commented Jul 13, 2018

@yuriyz we had implemented it with jsoneditor.js which doesn't supporting hide/show on change functionality.

@yuriyz

This comment has been minimized.

Contributor

yuriyz commented Jul 13, 2018

got it, it's not critical anyway.

@sahiliamsso

This comment has been minimized.

Contributor

sahiliamsso commented Aug 15, 2018

what is the purpose of highlighted labels as name is same as field name
image

@natt-tester

This comment has been minimized.

natt-tester commented Sep 12, 2018

@shekhar16 I think we should change useSsl to useSSL.

The string is unchanged in RC4, please follow @afroDC's idea

ssl

@natt-tester natt-tester reopened this Sep 12, 2018

@afroDC

This comment has been minimized.

afroDC commented Sep 12, 2018

@sahiliamsso is right and that field, sslTrustStoreFilePath, should have the caption read Directory Path to Trust Store

Also the caption under useSSL should read Enable SSL communication between Gluu Server and Redis cache

@shekhar16

This comment has been minimized.

Contributor

shekhar16 commented Sep 16, 2018

@yuriyz if I m going to change the label useSsl to useSSL than we need to change in oxauth code aswel.
because label should be same as Json attribute in oxtrust json editor.

@sahiliamsso @afroDC @natt-tester Once @yuriyz confirms the changes than only we can change the label otherwise it will break the functionality.

I updated the caption. here is screenshot.

image

@yuriyz

This comment has been minimized.

Contributor

yuriyz commented Sep 21, 2018

@shekhar16 changed in oxCore 3.1.4 and 4.0.0 (thus in oxauth too).

yuriyz added a commit that referenced this issue Sep 21, 2018

yuriyz added a commit that referenced this issue Sep 21, 2018

@yuriyz

This comment has been minimized.

Contributor

yuriyz commented Sep 21, 2018

changed name in oxTrust too. It should be available for validation in RC7 (3.1.4)

@yuriyz yuriyz closed this Sep 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment