New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clientID and clientSecret rows by default in passport #1020

Closed
jgomer2001 opened this Issue Jun 25, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@jgomer2001
Contributor

jgomer2001 commented Jun 25, 2018

In form at Configuration > Manage Authentication > Passport Authentication method

when the "add strategy" button is pressed we need to show two rows. One for clientID and another for clientSecret with empty values on the right hand side (or maybe a text indicating that they need to be filled).

This helps us making clearer how to add a new strategy (since clientID/secret are required for any social strategy to work).

@jgomer2001 jgomer2001 added this to the 3.1.4 milestone Jun 25, 2018

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Jun 26, 2018

I think the left side shouldn't be editable, Also both field shouldn't be removable like other custom field.

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Jun 26, 2018

image

syntrydy pushed a commit that referenced this issue Jun 26, 2018

jgomer2001 added a commit that referenced this issue Jun 27, 2018

Merge pull request #1023 from /issues/1020
Add default strategy fields #1020
@jgomer2001

This comment has been minimized.

Contributor

jgomer2001 commented Jun 27, 2018

@syntrydy I merged your PR #1023, can you copy your work to master as well?

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Jun 28, 2018

@yurem will merge 3.1.4 in master after the final release, so i don't think it is necessary to copy every work to master right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment