New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n support to passwordReminder.xhtml #1024

Closed
syntrydy opened this Issue Jun 28, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@syntrydy
Contributor

syntrydy commented Jun 28, 2018

Move all text to appropriate properties files.

@syntrydy syntrydy added this to the 3.1.4 milestone Jun 28, 2018

@syntrydy syntrydy self-assigned this Jun 28, 2018

@sakitA

This comment has been minimized.

sakitA commented Jun 28, 2018

Not only passwordReminder.xhtml. This problem occurs all oxtrust public pages. Such as registration, reset password and others

yurem added a commit that referenced this issue Jul 4, 2018

Merge pull request #1026 from /issues/1024
Move hardcode text to properties files #1024

@syntrydy syntrydy closed this Jul 11, 2018

@natt-tester

This comment has been minimized.

natt-tester commented Sep 11, 2018

I know it's an ongoing task, but it would be great to provide translations for all elements on a page if we start changing something. I think this area needs more improvement:

import

import2

@natt-tester natt-tester reopened this Sep 11, 2018

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Sep 11, 2018

@natt-tester That is the job of translator.
This issue was about moving hard code test from html/java code to properties files. The proper translation of these files isn't in the scope.

@syntrydy syntrydy closed this Sep 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment